Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters on non-string types can result in SQL errors #7

Closed
System-Glitch opened this issue Mar 30, 2023 · 0 comments · Fixed by #8
Closed

Filters on non-string types can result in SQL errors #7

System-Glitch opened this issue Mar 30, 2023 · 0 comments · Fixed by #8
Assignees
@System-Glitch
Labels
bug Something isn't working

Comments

@System-Glitch
Copy link
Member

Let's say we have an ID column of type INTEGER. If we have a filter id||$in||something, this will generate an error: ERROR: invalid input syntax for type integer.

All filters should be safe from DB errors.

Improve all operators to correctly generate SQL based on the received data type.
@System-Glitch System-Glitch added the bug Something isn't working label Mar 30, 2023
@System-Glitch System-Glitch self-assigned this Mar 30, 2023
@System-Glitch System-Glitch mentioned this issue Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@System-Glitch System-Glitch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type-safety in operators go-goyave/filter
1 participant
@System-Glitch