Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Utilize semgrep to check for common problems #688

Open
Civil opened this issue Sep 8, 2022 · 0 comments
Open

[FR] Utilize semgrep to check for common problems #688

Civil opened this issue Sep 8, 2022 · 0 comments

Comments

@Civil
Copy link
Member

Civil commented Sep 8, 2022

Based on a change: https://github.com/go-graphite/carbonapi/pull/686/files/4ae1e1f736fd004f24ee397c419245e520edfeac

It seems that it's worth to use semgrep to check that we copy metric before changing the tags (and maybe for some other problems).

That should reduce cognitive load on a reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant