Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate if it's possible to remove stopTime from responses #58

Closed
Civil opened this issue Mar 2, 2018 · 3 comments
Closed

investigate if it's possible to remove stopTime from responses #58

Civil opened this issue Mar 2, 2018 · 3 comments
Labels
grpc Tickets related to carbonzipper refactoring and grpc support wontfix

Comments

@Civil
Copy link
Member

Civil commented Mar 2, 2018

It seems that it's very easy to reconstruct stopTime out of data we receive. Is there any real need in having that in protocol?

@Civil Civil added the grpc Tickets related to carbonzipper refactoring and grpc support label Mar 2, 2018
@Civil
Copy link
Member Author

Civil commented Mar 2, 2018

@dgryski do you have any opinion about that? Maybe you remember the original reasoning behind having that in a first place?

@dgryski
Copy link
Member

dgryski commented Mar 2, 2018

The original reasoning was probably due the protobuf to match the pickle, which had that field. If you remove it remember you're going to need an upgrade path: first set consumers to always calculate it, then afterwards set the servers to stop sending it.

@Civil
Copy link
Member Author

Civil commented Mar 13, 2018

I think it's not worth to remove it. With new protocol messages it should be possible to convert them directly into pickle and almost directly to json

@Civil Civil added the wontfix label Mar 13, 2018
@Civil Civil closed this as completed Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grpc Tickets related to carbonzipper refactoring and grpc support wontfix
Projects
None yet
Development

No branches or pull requests

2 participants