Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitgen enhancement: generation of logging and metrics middlewares #910

Closed
shkov opened this issue Sep 7, 2019 · 3 comments
Closed

kitgen enhancement: generation of logging and metrics middlewares #910

shkov opened this issue Sep 7, 2019 · 3 comments

Comments

@shkov
Copy link

shkov commented Sep 7, 2019

I maintain a large enough project and i spend a lot of time when i write middlewares for collecting metrics or logs. I mean middlewares like this:

https://github.com/go-kit/kit/blob/master/examples/stringsvc3/instrumenting.go#L10

or

https://github.com/go-kit/kit/blob/master/examples/stringsvc3/logging.go#L9

It may not necessarily be a wrapper over a service. Also I would like to be able to wrap various objects like storage or something else.
Do you want to make it possible to generate some kinds of middlewares by kitgen? If you find this useful i would like to work on it and contribute.

@peterbourgon
Copy link
Member

If you want to try I would happily review the PR, but I think kitgen is basically abandonware at this point, I'm not sure it's worth investing in.

@xescugc
Copy link
Contributor

xescugc commented Sep 9, 2019

If it's not plan to work on kitgen, maybe would be good to remove/deprecate it from go-kit and also link on the README the possible solutions (some linked here #70).

WDYT?

@peterbourgon
Copy link
Member

Probably a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants