-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured logging as used in log15/logrus #97
Comments
@tonyhb I am a heavy user and one of the maintainers of log15, so I am familiar with the feature you linked to. Honestly, I've never felt the need to use that feature. I would like to hear more about your experience to get some perspective on the benefits of this feature. |
@ChrisHines for me it's only the structure and ease of readability of using map-like arguments instead of varargs — though that's about the only reason. It's why I'm a huge fan of Logrus' |
@tonyhb I am interested to see an example of how you use Logrus' One of the early proposals for the Go kit log API had a Logrus style API. I argued against that style here: #21 (comment). |
I do see the value in having typed arguments to Log, especially (perhaps only) for applications using log-structured data, rather than simple application logs. But I'd expect all of those use cases would have application-specific types, and they'd all boil down to wrappers around the existing API anyway, so I'm not sure how much value an explicit Fields type would provide. |
Closing this as out of scope for the core log package. |
Log15 has a very nice API for structured logging which is compatible with varargs style logging (see here: https://github.com/inconshreveable/log15#faq).
Could this be implemented?
The text was updated successfully, but these errors were encountered: