We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using sync logger and the given logger panic, that sync logger can't be reuse again because of forever locked mutex.
Can we just defer the Unlock()?
Unlock()
The text was updated successfully, but these errors were encountered:
Log should never panic, and if it does, you shouldn't recover from it.
But, I have no objection to changing this code to defer the unlock. @ChrisHines?
defer
Sorry, something went wrong.
Yes, using a defer is fine.
Successfully merging a pull request may close this issue.
When using sync logger and the given logger panic, that sync logger can't be reuse again because of forever locked mutex.
Can we just defer the
Unlock()
?The text was updated successfully, but these errors were encountered: