Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

TestConst issue (possibly darwin specific) #145

Open
quarnster opened this issue Apr 18, 2014 · 6 comments
Open

TestConst issue (possibly darwin specific) #145

quarnster opened this issue Apr 18, 2014 · 6 comments

Comments

@quarnster
Copy link
Contributor

Sorry, never filed this as a separate issue and I couldn't find an open issue number for it so creating it now as it still happens

=== RUN TestConst
--- FAIL: TestConst (0.34 seconds)
    utils_test.go:257: Output did not match: ["0" "1" "1 1" "1 1 1 4" "2147483647" "-2147483648" "2147483647" "-127" "false" "10000000000" "1" "3"] (actual) != ["0" "1" "1 1" "1 1 1 4" "2147483647" "-2147483648" "2147483647" "-127" "true" "10000000000" "1" "3"] (expected)

(originally from: #70 (comment))

@axw
Copy link
Member

axw commented Apr 18, 2014

Thanks. Is this on trunk, or the libgo branch?

@quarnster
Copy link
Contributor Author

It's with master, I can't get the libgo branch to compile:

14:44 ~/code/go/src/code.google.com/p/go.tools $ hg summary
parent: 851:845b6b3367d3 tip
 go.tools/go/gccgoimporter: use gccgo -dumpversion
branch: default
commit: 1 unknown (clean)
update: (current)
14:44 ~/code/go/src/code.google.com/p/go.tools $ go test -v github.com/go-llvm/llgo/llgo
# github.com/go-llvm/llgo
../../../github.com/go-llvm/llgo/compiler.go:239: undefined: gccgoimporter.PackageInit
FAIL    github.com/go-llvm/llgo/llgo [build failed]
14:44 ~/code/go/src/code.google.com/p/go.tools $

@axw
Copy link
Member

axw commented Apr 18, 2014

Okay. If you want to try libgo, you'll need to clpatch these two:
https://codereview.appspot.com/78740043
https://codereview.appspot.com/78780043

@quarnster
Copy link
Contributor Author

Hmm, so does llgo-dist require gccgo now? Last I tried gccgo wasn't buildable on Darwin, but I don't know what the current status is. I'll see if I can make any progress with gccgo and will report back

@axw
Copy link
Member

axw commented Apr 18, 2014

Hmm, so does llgo-dist require gccgo now? Last I tried gccgo wasn't buildable on Darwin, but I don't know what the current status is. I'll see if I can make any progress with gccgo and will report back

For the time being, yes, but just for linking (you could just -lgo -lgobegin, I'm fairly sure). I briefly looked into rebuilding libgo with clang and llgo, but didn't get very far before getting distracted. I will get back to it soon, I hope.

@quarnster
Copy link
Contributor Author

Well, I wasn't able to get gccgo running so will hold out until it's not needed anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants