Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ZMPOP command #2408

Merged
merged 27 commits into from Feb 22, 2023

Conversation

SoulPancake
Copy link
Contributor

@SoulPancake SoulPancake commented Jan 31, 2023

Adding support for ZMPOP

@SoulPancake SoulPancake marked this pull request as ready for review January 31, 2023 17:56
@monkey92t
Copy link
Collaborator

monkey92t commented Feb 1, 2023

I don't know how the test passes, I run this PR test and I get the error:

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0008c5050>: {
          s: "redis: can't parse reply=\"*1\" reading string",
      }
      redis: can't parse reply="*1" reading string
  occurred
  In [It] at: /Users/monkey/Desktop/redis/commands_test.go:3592

Oh, See #2411

@SoulPancake SoulPancake closed this Feb 1, 2023
@SoulPancake
Copy link
Contributor Author

Closing till I fix and debug the tests , will re-open once it is done

@SoulPancake SoulPancake reopened this Feb 13, 2023
@SoulPancake SoulPancake reopened this Feb 14, 2023
@SoulPancake SoulPancake marked this pull request as draft February 14, 2023 16:04
@SoulPancake
Copy link
Contributor Author

Hey @monkey92t I worked on this and learned from your implementation of LMPOP yesterday, I wrote tests from the examples in https://redis.io/commands/zmpop/
Kindly review it once and let me know if any changes are needed.

@SoulPancake SoulPancake marked this pull request as ready for review February 14, 2023 16:30
@SoulPancake
Copy link
Contributor Author

@monkey92t @chayim Should I rename the command to ZArrayWithKeyCmd ( matching the standard from
ZWithKey ) ?

@SoulPancake
Copy link
Contributor Author

@monkey92t Can you please review this if possible

commands.go Outdated Show resolved Hide resolved
commands.go Show resolved Hide resolved
@chayim
Copy link
Contributor

chayim commented Feb 19, 2023

@SoulPancake overall it looks good. My comment was literally only a nit. CI failures don't appear related.

@monkey92t or @vladvildanov you have more experience here. Does this frequently happen with CI in this project?

chayim
chayim previously approved these changes Feb 19, 2023
@monkey92t
Copy link
Collaborator

For the name ZArrayWithKeyCmd, in the go language, slice is generally used, we can change it to ZSliceWithKeyCmd

@monkey92t
Copy link
Collaborator

For commands with complex parameters, we should add some comments and usage examples.

monkey92t
monkey92t previously approved these changes Feb 21, 2023
commands.go Outdated Show resolved Hide resolved
commands.go Outdated Show resolved Hide resolved
command.go Outdated Show resolved Hide resolved
commands.go Show resolved Hide resolved
@monkey92t monkey92t merged commit 621c02c into redis:master Feb 22, 2023
@SoulPancake
Copy link
Contributor Author

Thanks everyone for their valuable comments and suggestions, Learning a lot @chayim @monkey92t @vladvildanov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants