Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for COMMAND GETKEYS & COMMAND GETKEYSANDFLAGS #2500

Merged
merged 23 commits into from Mar 25, 2023
Merged

Add support for COMMAND GETKEYS & COMMAND GETKEYSANDFLAGS #2500

merged 23 commits into from Mar 25, 2023

Conversation

SoulPancake
Copy link
Contributor

Fixes #2388

@SoulPancake
Copy link
Contributor Author

Hey @monkey92t @chayim @vmihailenco
I have done this implementation and I have written the test cases from the official docs.
Please review it.

@SoulPancake SoulPancake marked this pull request as ready for review March 24, 2023 12:46
monkey92t
monkey92t reviewed Mar 24, 2023
View reviewed changes
command.go Outdated Show resolved Hide resolved
monkey92t
monkey92t reviewed Mar 24, 2023
View reviewed changes
commands.go Outdated Show resolved Hide resolved
monkey92t
monkey92t reviewed Mar 24, 2023
View reviewed changes
commands.go Outdated Show resolved Hide resolved
@SoulPancake SoulPancake reopened this Mar 25, 2023
@SoulPancake SoulPancake marked this pull request as draft March 25, 2023 04:41
@SoulPancake SoulPancake marked this pull request as ready for review March 25, 2023 06:11
@SoulPancake
Copy link
Contributor Author

I've done all the changes as requested, Can you please take a look? @monkey92t

@monkey92t monkey92t merged commit 984bc28 into redis:master Mar 25, 2023
3 checks passed
@monkey92t
Copy link
Collaborator

I still have some doubts about this PR, and I will consider improving it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkey92t monkey92t monkey92t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for COMMAND GETKEYSANDFLAGS command
2 participants
@SoulPancake @monkey92t