Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code and fix go vet #2696

Merged
merged 14 commits into from Sep 20, 2023
Merged

Format code and fix go vet #2696

merged 14 commits into from Sep 20, 2023

Conversation

peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Sep 9, 2023

here I am using go 1.21.1 and

  1. I run go fix ./...
  2. Then I run make fmt
  3. And finally I run go vet ./... and fix the following issues:
# github.com/redis/go-redis/v9/doctests_test
doctests/lpush_lrange_test.go:11:1: ExampleLPushLRange refers to unknown identifier: LPushLRange
doctests/set_get_test.go:11:1: ExampleSetGet refers to unknown identifier: SetGet

based on the following rules

https://pkg.go.dev/testing#hdr-Examples

enjoy

@ofekshenawa ofekshenawa merged commit e8ad794 into redis:master Sep 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofekshenawa ofekshenawa ofekshenawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peczenyj @ofekshenawa