New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic type Repository wrapper #318
Conversation
Fs02
commented
Oct 14, 2022
•
edited
edited
- Simple wrapper to provide type safety to repository
- Rename record/records to be entity/entities, because the new generic repository is named as EntityRepository
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 35 +2
Lines 2766 2826 +60
=========================================
+ Hits 2766 2826 +60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hello I work of the R&D department at @ditrit we are very interested in this type of modifications. Currently we are implementing a Generic repository on top of gorm, which is far from ideal... |
Hi @slashformotion, I'm glad that you are interested in this, this will be merged soon and support for if you've any feedback or improvement idea, let me know |
for a cleaner git history you should probably not merge master into anything, you should rebase |
also, with squash merge, there's no need to enable "allow force-push", which I'm very against with 🙈 |
interesting , I will look into it |