Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scanMulti to only call scan once #339

Merged
merged 8 commits into from Aug 19, 2023
Merged

Refactor scanMulti to only call scan once #339

merged 8 commits into from Aug 19, 2023

Conversation

Fs02
Copy link
Member

@Fs02 Fs02 commented Aug 19, 2023

  • Refactor scanMulti to only call scan once, adapting recent changes in go 1.21

fix: #336

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8750e2c) 100.00% compared to head (7d5559a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #339   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2826      2828    +2     
=========================================
+ Hits          2826      2828    +2     
Files Changed Coverage Δ
collection.go 100.00% <100.00%> (ø)
cursor.go 100.00% <100.00%> (ø)
document.go 100.00% <100.00%> (ø)
util.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fs02 Fs02 marked this pull request as ready for review August 19, 2023 10:30
@Fs02 Fs02 merged commit ea91f66 into master Aug 19, 2023
12 checks passed
@Fs02 Fs02 deleted the fix-scan-multi branch August 19, 2023 10:47
pattern-hunter pushed a commit to pattern-hunter/rel that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preload fails with go 1.21.0
1 participant