Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body is written multiple times #743

Closed
patrikeh opened this issue Oct 30, 2023 · 2 comments · Fixed by #745
Closed

Request body is written multiple times #743

patrikeh opened this issue Oct 30, 2023 · 2 comments · Fixed by #745

Comments

@patrikeh
Copy link

patrikeh commented Oct 30, 2023

In v2.10.0, I've observed an issue where the request body passed to .SetBody(...) is intermittently written multiple times under certain conditions.

From what I gather, it is somehow related to the retry mechanism, or at the very least I was only able to reproduce by triggering that.

In the repro here, I ping an httptest mock endpoint triggering the retry mechanism, and observe the JSON request body being written multiple consecutive times e.g.


{ <some-json> }{ <some-json> }

This issue does not occur in v2.9.1.

@iporer
Copy link

iporer commented Nov 2, 2023

My projcet recurred this bug. Hope fix.
For more information, we tried all versions 2.8.0-2.10.0 and recurred in those versions.

@lattwood
Copy link
Contributor

lattwood commented Nov 2, 2023

@patrikeh thanks for throwing that test case together, really helped with tracking the issue down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants