Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After calling the browser.Close make sure all goroutines will stop properly #49

Closed
ysmood opened this issue Jun 4, 2020 · 0 comments
Closed

After calling the browser.Close make sure all goroutines will stop properly #49

ysmood opened this issue Jun 4, 2020 · 0 comments
Labels
bug When you are sure about it's a bug

Comments

@ysmood
Copy link
Member

ysmood commented Jun 4, 2020 •
edited
Loading

Use runtime.Stack(buf, true) after calling browser.Close() to exam if any orphan goroutine exists.

Currently, the WebSocket read will hang.
@ysmood ysmood added the bug When you are sure about it's a bug label Jun 4, 2020
@ysmood ysmood closed this as completed in f3c3a0d Jun 8, 2020
@ysmood ysmood reopened this Jun 8, 2020
@ysmood ysmood closed this as completed in 51c19e2 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug When you are sure about it's a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ysmood