Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using UserDataDir ignores leakless(false) #800

Closed
roachadam opened this issue Feb 9, 2023 · 4 comments
Closed

Using UserDataDir ignores leakless(false) #800

roachadam opened this issue Feb 9, 2023 · 4 comments
Labels
question Questions related to rod

Comments

@roachadam
Copy link

roachadam commented Feb 9, 2023

Rod Version: v0.112.4

path := "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe"

l := launcher.New().
  Headless(false).
  Devtools(false).
  Leakless(false).
  Devtools(true).
  UserDataDir("./test").
  Bin(path)

browser = rod.New().
  NoDefaultDevice().
  ControlURL(controlURL).
  MustConnect()

What you got

panic: fork/exec C:\Users\x\AppData\Local\Temp\leakless-0c3354cd58f0813bb5b34ddf3a7c16ed\leakless.exe: Operation did not complete successfully because the file contains a virus or potentially unwanted software.

goroutine 1 [running]:
github.com/go-rod/rod/lib/utils.glob..func2({0xd62ae0?, 0xc00049c270?})
C:/Users/x/go/pkg/mod/github.com/go-rod/rod@v0.112.4/lib/utils/utils.go:65 +0x25
github.com/go-rod/rod.genE.func1({0xc00006f7a0?, 0x0?, 0x0?})
C:/Users/x/go/pkg/mod/github.com/go-rod/rod@v0.112.4/must.go:36 +0x5a
github.com/go-rod/rod.(*Browser).MustConnect(0xc000140b40)
C:/Users/x/go/pkg/mod/github.com/go-rod/rod@v0.112.4/must.go:51 +0x89

What you expected to see

Leakless should not be used

What have you tried to solve the question

Tried with and without custom chrome path. Tried with just userdatadir and leakless as options

@roachadam roachadam added the question Questions related to rod label Feb 9, 2023
@ysmood ysmood closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2023
@ysmood ysmood added duplicate This issue or pull request already exists and removed question Questions related to rod labels Feb 9, 2023
@roachadam
Copy link
Author

roachadam commented Feb 9, 2023

Duplicated with #739

Is this a duplicate? I'm not concerned with leakleas being detected as a virus, i'm wondering why it's being used when i have it set to false.

@ysmood ysmood added question Questions related to rod and removed duplicate This issue or pull request already exists labels Feb 10, 2023
@ysmood
Copy link
Member

ysmood commented Feb 10, 2023

Where's your MustLaunch call? Could you compare your code with the example code?

@ysmood ysmood reopened this Feb 10, 2023
@ysmood ysmood closed this as completed Feb 10, 2023
@roachadam
Copy link
Author

Where's your MustLaunch call? Could you compare your code with the example code?

controlURL, _ := l.Launch()
browser = rod.New().
  NoDefaultDevice().
  ControlURL(controlURL).
  MustConnect()

@ysmood
Copy link
Member

ysmood commented Feb 10, 2023

You code only has MustConnect, where's MustLaunch? Please read my words carefully.

Please compare your code with the tutorial code line by line, you will understand why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions related to rod
Projects
None yet
Development

No branches or pull requests

2 participants