Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Shiori is behind a reverse proxy (patch with --webroot option), the extension doesn't connect anywhere but the root of the URL. #21

Open
lawrencecandilas opened this issue Feb 7, 2021 · 5 comments

Comments

@lawrencecandilas
Copy link

This commit fixes by making the new URL calls append the API path to the server URL config string instead of using 2 parameters to the URL() function.

@efrecon
Copy link
Contributor

efrecon commented Apr 29, 2022

I proposed a fix through #32

@l0b0
Copy link

l0b0 commented Oct 11, 2023

Has this been fixed by #32? If so, how do I actually use it? I tried using the base URL "https://[omitted]/shiori/" in the "Server" field in the configuration, but it must be talking to the wrong URL, because I get a HTTP 404 from the server.

@efrecon
Copy link
Contributor

efrecon commented Oct 12, 2023

I just checked what I have: I start shiori with -r /shiori and have a reverse proxy in front. In the webextension, I have what you have. I am running caddy as the reverse proxy, if that helps in anyway.

(I suppose you are self-hosting this).

@l0b0
Copy link

l0b0 commented Oct 12, 2023

Oh, maybe my trailing slash (--webroot /shiori/) is breaking things? The web interface works fine though.

@fmartingr
Copy link
Member

Hey @l0b0, are you using the latest release or the latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants