Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for passing bookmark URL in as query parameter #189

Closed
timshannon opened this issue Oct 2, 2019 · 3 comments
Closed

Option for passing bookmark URL in as query parameter #189

timshannon opened this issue Oct 2, 2019 · 3 comments
Labels
priority:low type:enhancement New feature or request

Comments

@timshannon
Copy link

timshannon commented Oct 2, 2019

Since bookmarklet support has been dropped favor of the extension (#180), it be nice to have a fall back for any other scenario where the extension doesn't work (other browsers, locked down browser environments, etc).

Simply accepting a URL parm at the root page that automatically opens the Add bookmark dialog and pre-populates the URL from the parameter value would allow for this.

https://my-shiori-url.com?add_url=https%3A%2F%2Fgoogle.com

I may add a PR for this, if you think it's a reasonable addition. It should be able to be done entirely in the frontend Vue code.

@deanishe deanishe added type:enhancement New feature or request priority:low labels Aug 7, 2020
@deanishe
Copy link
Contributor

deanishe commented Aug 7, 2020

Bookmarklet support is important to me. It's simpler, and much more widely supported, than browser extensions.

@clach04
Copy link

clach04 commented Aug 16, 2020

I don't have a strong opinion on what the URL should be but #84 with commit 4b93937 introduced /submit?url= - see:

This was a fallback for non-https installations (I'm personally running a private instance withOUT https).

I'd recommend adopting the previous URL (and bookmarklet) support.

@deanishe
Copy link
Contributor

I'd recommend adopting the previous URL (and bookmarklet) support.

Was that removed? That's definitely going back in. Looks like it worked perfectly.

A GET-based submission endpoint is essential, imo. It allows you to integrate Shiori with almost anything.

@go-shiori go-shiori locked and limited conversation to collaborators Feb 5, 2022
@fmartingr fmartingr converted this issue into discussion #333 Feb 5, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
priority:low type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants