Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Strip UTM params from URLs (optionally?) #26

Closed
heliostatic opened this issue Mar 2, 2018 · 3 comments
Closed

Feature Request: Strip UTM params from URLs (optionally?) #26

heliostatic opened this issue Mar 2, 2018 · 3 comments
Labels
type:enhancement New feature or request

Comments

@heliostatic
Copy link

When adding a bookmark, add an option to strip UTM parameters.

Last feature request for now, I promise!

@RadhiFadlillah
Copy link
Collaborator

Hey, I think it should be easy enough to do. You can expect this feature to be added on this or next week.

However, should shiori strips UTM parameter by default or if only specified by user ?

@RadhiFadlillah RadhiFadlillah added the type:enhancement New feature or request label Mar 5, 2018
@heliostatic
Copy link
Author

I think strip by default. Most of the time of the time users won't care about preserving marketing data.

@RadhiFadlillah
Copy link
Collaborator

RadhiFadlillah commented Mar 5, 2018

Done in d167379.

After thinking about it, I make the UTM parameters will always be removed, because those parameter is useless for the reader. So, I don't think there are any need to add flag for keeping the UTMs.

I will close this issue for now, feel free to reopen it if you have different idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants