Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old cache if updating cache done without problem #634

Closed
Monirzadeh opened this issue Jul 7, 2023 · 0 comments · Fixed by #683
Closed

Remove old cache if updating cache done without problem #634

Monirzadeh opened this issue Jul 7, 2023 · 0 comments · Fixed by #683
Assignees
@Monirzadeh
Labels
type:bug Something isn't working
Milestone
1.6.0

Comments

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Jul 7, 2023 •
edited

We will need to be cautious in the future and do not remove content, archive or bookmark if we find problems when updating the cache. We could save the new one to a temporary location while we work, and if everything succeeds, replace the current one. We can create an issue for this.

Originally posted by @fmartingr in #623 (comment)
@Monirzadeh Monirzadeh mentioned this issue Jul 7, 2023
Merged
22 tasks
@Monirzadeh Monirzadeh changed the title remove old cache if updating cache done without problem Remove old cache if updating cache done without problem Jul 8, 2023
@fmartingr fmartingr added the type:bug Something isn't working label Jul 8, 2023
@fmartingr fmartingr mentioned this issue Jul 21, 2023
Open
@fmartingr fmartingr added this to the 1.6.3 milestone Jul 21, 2023
@fmartingr fmartingr mentioned this issue Jul 21, 2023
Closed
This was referenced Jul 27, 2023
Closed
Merged
@fmartingr fmartingr mentioned this issue Jul 29, 2023
Closed
@fmartingr fmartingr modified the milestones: 1.6.3, 1.5.6 Aug 20, 2023
@fmartingr fmartingr modified the milestones: 1.5.6, 1.6.0 Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monirzadeh Monirzadeh

Labels
type:bug Something isn't working
Projects
Roadmap
Archived in project
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

fix: Ensure bookmark files are correctly downloaded before deleting current ones Monirzadeh/shiori
2 participants
@fmartingr @Monirzadeh