Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload transcription API wasn't reading the data from the post #229

Merged
merged 3 commits into from May 11, 2023

Conversation

mattkanwisher
Copy link
Contributor

Looks like it was always reading from disk instead of reading the post data

api/openai.go Outdated Show resolved Hide resolved
@mudler
Copy link
Owner

mudler commented May 11, 2023

Looks like it was always reading from disk instead of reading the post data

really weird, I remember testing it - this just shows we need CI coverage here.. however I like this approach more! Thanks!

@mattkanwisher
Copy link
Contributor Author

Looks like it was always reading from disk instead of reading the post data

really weird, I remember testing it - this just shows we need CI coverage here.. however I like this approach more! Thanks!

yeah so if you have the file where you have the go code it all works ;) but if you actually use curl from a remote machine it doesn't have the file

@mudler
Copy link
Owner

mudler commented May 11, 2023

Looks like it was always reading from disk instead of reading the post data

really weird, I remember testing it - this just shows we need CI coverage here.. however I like this approach more! Thanks!

yeah so if you have the file where you have the go code it all works ;) but if you actually use curl from a remote machine it doesn't have the file

🤦 of course! good catch! thank you !

@mudler mudler merged commit 6b5e2b2 into mudler:master May 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants