Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more test-cases and remove dev container #433

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

Aisuko
Copy link
Collaborator

@Aisuko Aisuko commented May 30, 2023

Description

The current dev container:

  • It is hard to support the arm/arrch64 environment
  • It is hard to support debugging mode for the test files, it needs to install many files to support debugging mode and it did not work well when we trigger debugging mode for test cases.
  • It is locked when we use the codespace to open the project, I have tested debug in the codespace Linux environment. The debug processing was running well. So, we should remove it.
    image

Also, include:

  • Add model folder to ignore file
  • Add model folder to make clean
  • Add a small test for configure.go

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Aisuko <urakiny@gmail.com>
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here, thanks @Aisuko !

@mudler mudler merged commit 49ce249 into master May 30, 2023
9 checks passed
@mudler mudler deleted the feat/testcases branch May 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants