Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not build from the same container #434

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: do not build from the same container #434

merged 1 commit into from
May 30, 2023

Conversation

mudler
Copy link
Owner

@mudler mudler commented May 30, 2023

We are not cleaning up properly, and this causes leftovers to stay around when rebuilding the first time. This ends up to link objects during startup of the container with objects compiled with a different CPU flagset, and giving out SIGILL like:

chatbot-ui-api-1      | SIGILL: illegal instruction
chatbot-ui-api-1      | PC=0xa17ced m=7 sigcode=2
chatbot-ui-api-1      | signal arrived during cgo execution
chatbot-ui-api-1      | instruction bytes: 0x62 0xf2 0xf5 0x8 0x3f 0xc0
0xc4 0xe1 0xf9 0x7e 0xc2 0x48 0x1 0xd0 0xf 0x92
chatbot-ui-api-1      |
chatbot-ui-api-1      | goroutine 31 [syscall]:
chatbot-ui-api-1      | runtime.cgocall(0x97f700, 0xc0002d6460)
chatbot-ui-api-1      |         /usr/local/go/src/runtime/cgocall.go:157
+0x5c fp=0xc0002d6438 sp=0xc0002d6400 pc=0x44cd3c

Description

This PR might possibly alleviate #288 #86

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

We are not cleaning up properly, and this causes leftovers to stay
around when rebuilding the first time. This ends up to link objects
during runtime, and giving out SIGILL like:

```
chatbot-ui-api-1      | SIGILL: illegal instruction
chatbot-ui-api-1      | PC=0xa17ced m=7 sigcode=2
chatbot-ui-api-1      | signal arrived during cgo execution
chatbot-ui-api-1      | instruction bytes: 0x62 0xf2 0xf5 0x8 0x3f 0xc0
0xc4 0xe1 0xf9 0x7e 0xc2 0x48 0x1 0xd0 0xf 0x92
chatbot-ui-api-1      |
chatbot-ui-api-1      | goroutine 31 [syscall]:
chatbot-ui-api-1      | runtime.cgocall(0x97f700, 0xc0002d6460)
chatbot-ui-api-1      |         /usr/local/go/src/runtime/cgocall.go:157
+0x5c fp=0xc0002d6438 sp=0xc0002d6400 pc=0x44cd3c
```

Signed-off-by: mudler <mudler@mocaccino.org>
@mudler mudler added the bug Something isn't working label May 30, 2023
@mudler mudler merged commit 6d71dd7 into master May 30, 2023
9 checks passed
@mudler mudler deleted the fix_rebuild branch May 30, 2023 13:53
@mudler mudler mentioned this pull request Jun 26, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant