ci: build Docker image variants #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sébastien Prud'homme <sebastien.prudhomme@gmail.com>
sebastien-prudhomme
changed the title
|
fantastic @sebastien-prudhomme! thank you 💯 ! |
mudler
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build Docker images variants. For now I propose to build also for cublas on cuda11 and cublas on cuda12.
Notes for Reviewers
I've switched to the docker metadata github action to compute docker tags and labels. The only difference is that tags corresponding to commit sha are prefixed by "sha-" and are on 7 characters instead of 8.
It's possible to remove the prefix if needed.
The 7 characters are the same short commit sha displayed everywhere on github.
Signed commits