Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [whisper] Partial support for verbose_json format in transcribe endpoint #721

Merged
merged 1 commit into from Jul 4, 2023

Conversation

ldotlopez
Copy link
Contributor

Extend the current output to be compatible with the custom_json format referenced in the OpenAI docs

This PR basically adds an extra field in response: 'segments', which contains text divided by time segments.

These changes can be useful for other tools that expect segmented text like some automatic subtitles or other tools like Buzz

Although support is not complete, those changes are enough to get Buzz working at least. More work is needed to perfectly support custom_json format.

@mudler mudler changed the title [whisper] Partial support for verbose_json format in transcribe endpoint feat: [whisper] Partial support for verbose_json format in transcribe endpoint Jul 4, 2023
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks. Also passes tests which are testing e2e whisper, so no regressions either

@mudler mudler merged commit a6839fd into mudler:master Jul 4, 2023
8 checks passed
@mudler mudler added the enhancement New feature or request label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants