Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve JSONSchema refs (planners) #774

Merged
merged 1 commit into from Jul 19, 2023
Merged

feat: resolve JSONSchema refs (planners) #774

merged 1 commit into from Jul 19, 2023

Conversation

mudler
Copy link
Owner

@mudler mudler commented Jul 19, 2023

Description

This PR adds compatibility to the JSONSchema notation $defs and $refs which allow to re-use objects across a schema.

This allows projects like https://github.com/stillmatic/gollum or https://github.com/jxnl/openai_function_call compatible.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mudler mudler marked this pull request as draft July 19, 2023 17:44
@mudler mudler marked this pull request as ready for review July 19, 2023 20:55
@mudler
Copy link
Owner Author

mudler commented Jul 19, 2023

far from perfect, but good for a first round of implementation

@mudler mudler merged commit 236497e into master Jul 19, 2023
14 checks passed
@mudler mudler deleted the grammar_ref branch July 19, 2023 20:56
@mudler mudler added the enhancement New feature or request label Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant