Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: symlink libphonemize in the container #831

Merged
merged 5 commits into from Jul 29, 2023
Merged

fix: symlink libphonemize in the container #831

merged 5 commits into from Jul 29, 2023

Conversation

mudler
Copy link
Owner

@mudler mudler commented Jul 28, 2023

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mudler
fix: symlink libphonemize in the container
fa4de05 
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
dave-gray101
dave-gray101 previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@dave-gray101 dave-gray101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will merge into my PR as well to see if that fixes the other test now that I've patched the expected model count locally.

@mudler mudler enabled auto-merge (squash) July 28, 2023 19:19
@dave-gray101 dave-gray101 self-requested a review July 28, 2023 22:08
dave-gray101
dave-gray101 previously approved these changes Jul 28, 2023
View reviewed changes
@mudler
fix: set default rope if not specified
f085baa 
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
dave-gray101
dave-gray101 previously approved these changes Jul 28, 2023
View reviewed changes
dave-gray101 and others added 2 commits July 29, 2023 02:37
@dave-gray101
1000 -> 10,000 for ropeFreqBase?
8b90ac2 
the error message talks about a default of 10k, so setting this to 10k instead of 1k experimentally.
@mudler
tests: set a small context_size
e70b91a 
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@mudler mudler disabled auto-merge July 29, 2023 08:38
@mudler
fix: set default rope freq base to 10000 during model load
00ccb8d 
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@mudler mudler merged commit 688f150 into master Jul 29, 2023
14 checks passed
@mudler mudler deleted the fix_tts branch July 29, 2023 10:47
@mudler mudler added the bug Something isn't working label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-gray101 dave-gray101 dave-gray101 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mudler @dave-gray101