Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.18.0 Docker image has no viewer UI #945

Closed
jchamberlain opened this issue Aug 29, 2023 · 5 comments · Fixed by #947
Closed

v0.18.0 Docker image has no viewer UI #945

jchamberlain opened this issue Aug 29, 2023 · 5 comments · Fixed by #947

Comments

@jchamberlain
Copy link
Contributor

As of the changes in #940/#941, the image that is pushed on release loads only the following HTML at /:

<pre>
<a href=".keep">.keep</a>
</pre>

I'm guessing this is because the "Publish Docker container" step does not include context: ., and thus is working on the Git context, which does not include the local filesystem changes like the addition of ui/dist.

@ARolek
Copy link
Member

ARolek commented Aug 29, 2023

@jchamberlain thanks for the report. There's one other report of someone having issues with the viewer: #942

@jchamberlain
Copy link
Contributor Author

Thanks @ARolek, I just left a comment there. It appears to be an unrelated issue: the output of tegola version always says "ui viewer: viewer not build" even when it did build successfully.

@ARolek
Copy link
Member

ARolek commented Aug 29, 2023

To follow up on @jchamberlain report, the following step in the CI appears to be where the issue is happening:

- name: Publish Docker edge container
if: github.ref == env.DEFAULT_BRANCH_REF
uses: docker/build-push-action@v4
with:
push: true
tags: ${{ env.DOCKERHUB_ORG }}/${{ env.DOCKERHUB_REPO }}:edge
platforms: linux/amd64,linux/arm64
build-args: ${{ env.BUILD_ARGS }}

And the context @jchamberlain is talking about is documented here

@ARolek
Copy link
Member

ARolek commented Aug 29, 2023

@manastyretskyi can you take a quick look at this one? Seems like all we need to do is add context: . to the action.

@manastyretskyi
Copy link
Contributor

@ARolek I will try to take a look at it later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants