Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner tests are excluded from build ? #2208

Open
KevinJCross opened this issue Feb 3, 2020 · 1 comment
Open

Scanner tests are excluded from build ? #2208

KevinJCross opened this issue Feb 3, 2020 · 1 comment
Labels
generate spec Related to spec generation from code question

Comments

@KevinJCross
Copy link

KevinJCross commented Feb 3, 2020

Problem statement

It seems the scanner tests are excluded ... well a lot of tests tbh.
Im trying to fix a bug but the tests I wish to run are not included in the build ?

go test ./...

its all about the
// +build !go1.11 which from the go lang doc is not an operating system and will make the test be skipped like ignore. maybe NOT(go1.11) was intended or just go1.12 ?

"
To keep a file from being considered for the build:

// +build ignore

(any other unsatisfied word will work as well, but “ignore” is conventional.)
"

I would suggest removing the // +build tag altogether.

@casualjim
Copy link
Member

For go 1.11+ we use moduels in the codescan package.
That build tag says for anything below go1.11. this is actually intended because for the newer go versions we use a different package that is module aware

@fredbi fredbi added generate spec Related to spec generation from code question labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generate spec Related to spec generation from code question
Projects
None yet
Development

No branches or pull requests

3 participants