Feature 664 group error only

[jaedle]

Implementation idea for #664.

Describe your changes

Usage

version: '3'

silent: true

output:
  group:
    error_only: true

tasks:
  passing: echo 'passing-output'
  failing: echo 'failing-output' && exit 1

> task passing
(no output)
> task failing
failing-output
task: Failed to run task "failing": exit status 1

Implementation

Enrich Group output by an error_only flag which should swallow the output (stdout + stderr) if any external command did not have a non zero exit code. By default this flag is disabled.

backwards comapatibility

Changes should not interfere with task files created in previous versions as the default behavior is not changed.

What's already done

• high level tests (task_test.go)
• tests for output writer
• code style (fmt & lint)
• documentation
• schema definition

I would love to have some feedback if this goes into the right direction. If so, I would love to continue working on it.

[andreynering]

Hi @jaedle!

Thanks for working on this!

This is in the right direction, but I commented a few changes before this can be merged.

Other than the documentation, something else missing the updating the schema.json to reflect this change. If you don't want to do that yourself, let us know and we'll do once merged.

[jaedle]

Hi @andreynering,

thanks for your feedback. I will try to catch up on your review comments on the weekend.

[jaedle]

Hey @andreynering,

as you have suggested a different approach (add a flag to output group instead of a new output group_error_only), it was way easier to start the implementation from scratch. I am sorry if this creates more effort on your side, but this was way cleaner.

I have updated the issue to reflect the new implementation idea.

I tried to implement all your review comments. If there is still anything missing on this pr, feel free leave a note.

[andreynering]

Thanks for your contribution @jaedle, it's very appreciated!