Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix special variables #1334

Merged
merged 5 commits into from Sep 15, 2023
Merged

fix special variables #1334

merged 5 commits into from Sep 15, 2023

Conversation

pd93
Copy link
Member

@pd93 pd93 commented Sep 14, 2023

Fixes #1331

  • fix: e.Dir not being set to the correct directory
  • fix: only create a cache if the node is remote

The issue was that e.Dir wasn't being set to the root taskfile location after reading the taskfiles, so it was set to the working directory instead.

This fix causes some issues with the cache directory for the remote taskfiles experiment, but fixing the core functionality is the priority.

@pd93 pd93 force-pushed the fix-special-variables branch 2 times, most recently from 43a2cdb to 73f8906 Compare September 14, 2023 21:50
@andreynering andreynering merged commit d1d312f into main Sep 15, 2023
12 checks passed
@andreynering andreynering deleted the fix-special-variables branch September 15, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROOT_DIR is current work dir
2 participants