Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repos with manually deleted hooks should be handled appropriately in the database and via vela sync command #852

Closed
KellyMerrick opened this issue Aug 31, 2023 · 0 comments · Fixed by go-vela/server#953
Closed

Repos with manually deleted hooks should be handled appropriately in the database and via vela sync command #852

KellyMerrick opened this issue Aug 31, 2023 · 0 comments · Fixed by go-vela/server#953
Assignees
@KellyMerrick
Labels
bug Indicates a bug

Comments

@KellyMerrick
Copy link
Contributor

KellyMerrick commented Aug 31, 2023 •
edited
Loading

Description

The command to sync all repos in an org will fail if one of the repos is inactive in the database. The below repo is inactive in the database.

$ vela sync repos --org KellyMerrick --all
FATA[0000] unable to update repo webhook for KellyMerrick/testrepo: PATCH https://github.com/api/v3/repos/KellyMerrick/testrepo/hooks/0: 404 Not Found []

Value

To keep the database in sync with the SCM, the sync command needs to be able to handle inactive repos.

Useful Information

  1. What is the output of vela --version?

v0.20.1

  1. What operating system is being used?
  1. Any other important details?
@KellyMerrick KellyMerrick added the bug Indicates a bug label Aug 31, 2023
@KellyMerrick KellyMerrick changed the title Archived/Deleted repos should be Archived/Deleted SCM repos should be handled appropriately in the database and via vela sync command Aug 31, 2023
@KellyMerrick KellyMerrick changed the title Archived/Deleted SCM repos should be handled appropriately in the database and via vela sync command Repos with manually deleted hooks should be handled appropriately in the database and via vela sync command Sep 6, 2023
@KellyMerrick KellyMerrick self-assigned this Sep 6, 2023
@KellyMerrick KellyMerrick mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KellyMerrick KellyMerrick

Labels
bug Indicates a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug(repo sync): ignore inactive repos go-vela/server
1 participant
@KellyMerrick