Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install - Please Don't Place Exe's In C:\Windows\System32 #131

Closed
mikebeckel opened this issue May 4, 2020 · 4 comments
Closed

Install - Please Don't Place Exe's In C:\Windows\System32 #131

mikebeckel opened this issue May 4, 2020 · 4 comments

Comments

@mikebeckel
Copy link

Please don't place EXE's in C:\Windows\System32. It's a OS folder and while it makes it easy to make your executable accessible as it's included in the System Path it's not the correct approach for several reasons.

  • It obfuscates the origin of your executable and can be interpreted as malware.
  • It requires that users have Administrative rights to modify

The best approach is to create an installer so that it can be installed to Program Files. The next best approach is for the user to place in into a directory of their choosing, such as their user profile, and update the User Path so that it's accessible from anywhere for that user.

@wass3r
Copy link
Collaborator

wass3r commented May 4, 2020

Thanks for the feedback. Is NSIS still the go-to for creating installers? Or do you have any recommendations?

@kneal
Copy link
Contributor

kneal commented May 5, 2020

@mikebeckel Do you know how common chocolatey is for windows users?
https://chocolatey.org/

We could potentially look into adding it there as well if that's generally seen as best practice.

@mikebeckel
Copy link
Author

NSIS or WIX are pretty common these days. Chocolatey usage is definitely picking up. It doesn't get around the admin rights issues of regular software install, however if the Vela CLI was installed into a user directory and the the user path updated then I could see this as a pretty viable solution.

@jbrockopp
Copy link
Contributor

Hello 👋

The Vela admins have decided to condense all existing issues into a single repo found @ go-vela/community.

For a direct link to your counterpart issue in that repo, you can find it linked yesterday in the history of this issue.

If you have any questions, please feel free to direct them to the community repo.

Thanks for your input and feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants