Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to Github PR comment events #112

Closed
KellyMerrick opened this issue Feb 21, 2020 · 2 comments
Closed

Respond to Github PR comment events #112

KellyMerrick opened this issue Feb 21, 2020 · 2 comments
Labels
feature Indicates a new feature

Comments

@KellyMerrick
Copy link
Contributor

Description

Respond to more PR comment events to trigger builds
- pull request review comments
- pull request reviews

Value

Why is this important? Who does it impact? Will this make something better, faster, etc?

Definition of Done

What is the end goal of this story?

Effort (Optional)

Estimated effort to complete this story? (Best Guess e.g. 1-2 days)

Impacted Personas (Optional)

Which personas will benefit from completing this story? (Users, Administrators, etc)

@KellyMerrick KellyMerrick added the feature Indicates a new feature label Feb 21, 2020
@annamalai87
Copy link
Contributor

@KellyMerrick Although I am interested to work on this issue, I have couple of questions before I can start working on this.

  1. If any comment/review should trigger build, we will have multiple builds for one PR. Also it may lead to multiple concurrent builds based on comment/review activity.

  2. What is the benefit of triggering the build based on the review comment?

@jbrockopp
Copy link
Contributor

jbrockopp commented May 28, 2020

Hello 👋

The Vela admins have decided to condense all existing issues into a single repo found @ go-vela/community.

For a direct link to your counterpart issue in that repo, you can find it linked yesterday in the history of this issue.

If you have any questions, please feel free to direct them to the community repo.

Thanks for your input and feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

No branches or pull requests

3 participants