Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check for token #337

Merged
merged 1 commit into from
Apr 8, 2021
Merged

fix: add check for token #337

merged 1 commit into from
Apr 8, 2021

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Apr 8, 2021

backport for 311ec51

@wass3r wass3r requested a review from a team as a code owner April 8, 2021 18:47
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #337 (311ec51) into v0.7.5 (5a3ffe3) will increase coverage by 0.68%.
The diff coverage is 79.03%.

❗ Current head 311ec51 differs from pull request most recent head d6363a3. Consider uploading reports for the commit d6363a3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           v0.7.5     #337      +/-   ##
==========================================
+ Coverage   86.62%   87.30%   +0.68%     
==========================================
  Files         116      123       +7     
  Lines        2930     3088     +158     
==========================================
+ Hits         2538     2696     +158     
+ Misses        321      301      -20     
- Partials       71       91      +20     
Impacted Files Coverage Δ
database/build.go 84.94% <0.00%> (-10.24%) ⬇️
source/github/access.go 96.96% <ø> (ø)
source/github/changeset.go 77.27% <ø> (ø)
source/github/deployment.go 86.58% <ø> (ø)
source/github/webhook.go 90.29% <ø> (ø)
database/user.go 79.06% <30.76%> (-20.94%) ⬇️
database/repo.go 79.20% <32.25%> (-20.80%) ⬇️
secret/vault/refresh.go 43.63% <33.33%> (ø)
source/github/authentication.go 79.10% <68.00%> (-3.51%) ⬇️
secret/vault/vault.go 95.09% <85.00%> (+1.64%) ⬆️
... and 38 more

@jbrockopp jbrockopp added the bug Indicates a bug label Apr 8, 2021
@wass3r wass3r merged commit cb43529 into v0.7.5 Apr 8, 2021
@wass3r wass3r deleted the v0.7.5-work branch April 8, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants