Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new --confirm/-c argument when deleting users to bypass prompt #86

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Added new --confirm/-c argument when deleting users to bypass prompt #86

merged 2 commits into from
Oct 10, 2023

Conversation

KaibutsuX
Copy link
Contributor

No description provided.

kolaente
kolaente requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issues (run mage check:golangci-fix).

@KaibutsuX
Copy link
Contributor Author

FYI, golangci-lint run --fix exited 1 with:

INFO [runner] linters took 12.545000771s with stages: goanalysis_metalinter: 12.474141491s 
pkg/routes/caldav/listStorageProvider.go:177:19: G601: Implicit memory aliasing in for loop. (gosec)
				task:         &t.Task,
				              ^
pkg/routes/caldav/listStorageProvider.go:180:37: G601: Implicit memory aliasing in for loop. (gosec)
			r := data.NewResource(getTaskURL(&t.Task), &rr)
			                                 ^
pkg/routes/caldav/listStorageProvider.go:414:23: G601: Implicit memory aliasing in for loop. (gosec)
		labelMap[l.Title] = &l.Label
		                    ^

@kolaente
Copy link
Member

Which golangci-lint version are you using?

@KaibutsuX
Copy link
Contributor Author

Which golangci-lint version are you using?

golangci-lint has version v1.54.2 built with go1.21.1 from (unknown, mod sum: "h1:oR9zxfWYxt7hFqk6+fw6Enr+E7F0SN2nqHhJYyIb0yo=") on (unknown)

@kolaente
Copy link
Member

Rebase and try again

@KaibutsuX
Copy link
Contributor Author

Seems rebase resolved the linter issue

@kolaente kolaente merged commit 0654d7c into go-vikunja:main Oct 10, 2023
vikunja-bot pushed a commit that referenced this pull request Oct 10, 2023
@KaibutsuX @kolaente
feat(cli): added --confirm/-c argument when deleting users to bypass …
0769d59 
…prompt (#86)

Reviewed-On: #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KaibutsuX @kolaente