Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Filtering Lists #182

Closed
mtettke123 opened this issue Aug 4, 2022 · 11 comments
Closed

Bug: Filtering Lists #182

mtettke123 opened this issue Aug 4, 2022 · 11 comments
Labels
bug Something isn't working

Comments

@mtettke123
Copy link

Using the "filter" button in list view, I can filter "assignees" (small bug: When selecting a person, you can see the selected person a couple of millisecons, then the field is empty again, but the filter works).

Using the "new saved filter" setting in namespaces/lists, filtering with an assignee always returns an empty list.

Small workflow improvement: it would be great if filters in list view could be saved ("save this filter").

@kolaente
Copy link
Member

kolaente commented Aug 4, 2022

Can you reproduce this on try?

@kolaente kolaente added the bug Something isn't working label Aug 4, 2022
@mtettke123
Copy link
Author

Well, surprinsingly no. Filtering works here (but I'm using unstable, shouldn't this be the same?). The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to:
grafik

@kolaente
Copy link
Member

kolaente commented Aug 4, 2022

Well, surprinsingly no. Filtering works here

Then it's probably already fixed in unstable.

but I'm using unstable, shouldn't this be the same?

It should, when did you last upgrade?

The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to:

That sounds like another bug. I'll take a look.

@mtettke123
Copy link
Author

Filtering seems to be solved. Just updated. works.

The small bug is still there (in my installation: selected person disappers like if no one is selected, but filter works)...

@glungtung
Copy link

I confirm
Person disappears immediatly after selection in Assignees
But filter can be created and is working

@kolaente
Copy link
Member

The cause of this problem is a little complicated and has two parts.

In the frontend, the bug occurs because the filter value changes after a user was selected. This triggers a rebuild of all filter values which for the assignee filter means a search request to get the full name etc of the user. BUT the assignee filter only stores user ids and the user search endpoint does not handle those (to prevent usernames leaking by just increasing the id). Therefore, the search returns no results and the user disappears. The filter component does this to show the correct values if the filter changed from the outside (aka was just loaded).
This can be fixed with a check if there's already data loaded and not loading it if that's the case. Still not ideal because then it won't update if the filter is changed from the outside again after loading it but we're not doing that at the moment.

The other problem is the mentioned filter search: Because we can't lookup user IDs we should ideally save usernames. They are unique and relatively un-guessable (no enumeration possible). If we save usernames instead of IDs we'll need to change the filter logic so that it is able to search by username instead of ID. Possible. but a breaking change.

@ToniMurcia
Copy link

Filtering by asignee works great in list view but not in kanban, it always returns an empty list.

@kolaente
Copy link
Member

kolaente commented Sep 1, 2022

Filtering by asignee works great in list view but not in kanban, it always returns an empty list.

Filters are not supported for kanban right now.

@ToniMurcia
Copy link

ToniMurcia commented Sep 2, 2022

Do you mean "Filters are not supported for kanban" only for assignee field? Because the rest of fields work great when filtering in kanban view: labels, priority, progress, etc.

@kolaente
Copy link
Member

kolaente commented Sep 2, 2022

I mean you can't filter by Kanban buckets or view a saved filter in Kanban view.

@kolaente
Copy link
Member

This has been fixed in the meantime.

@kolaente kolaente transferred this issue from go-vikunja/frontend Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants