Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CORS for API endpoints #110

Closed
bitpshr opened this issue Apr 2, 2019 · 1 comment
Closed

Enable CORS for API endpoints #110

bitpshr opened this issue Apr 2, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@bitpshr
Copy link
Contributor

bitpshr commented Apr 2, 2019

While the SDK will work in both a browser and a node context from a JavaScript perspective, the backing API that the SDK uses by default at https://api.goabstract.com still has CORS enabled and can't be accessed by external domains at this time.

We should enable CORS for SDK-supported endpoints and document any necessary configuration.
@bitpshr bitpshr added the enhancement New feature or request label Apr 2, 2019
@bitpshr bitpshr mentioned this issue Apr 2, 2019
Closed
@tommoor
Copy link
Contributor

tommoor commented Oct 22, 2019

Great news, we've now opened up CORS on the API to any domain. Happy hacking!

@tommoor tommoor closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitpshr @tommoor