Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #3087042 by albertoalaejos: email button for comment on comment… #1549

Merged
merged 2 commits into from Oct 11, 2019
Merged

issue #3087042 by albertoalaejos: email button for comment on comment… #1549

merged 2 commits into from Oct 11, 2019

Conversation

albertoalaejos
Copy link
Contributor

@albertoalaejos albertoalaejos commented Oct 10, 2019 •
edited by jaapjan

Reply to this comment button bring you to the commented entity

Problem

Previously we solved the issue for reply links in e-mails regarding comments on posts and nodes. It still needs to be solved for comments on comments.

Solution

Change the link in the email to reply to the entity instead of the comment on the post.

Issue tracker

https://www.drupal.org/project/social/issues/3087042

How to test

  • Login as LU X
  • Create a topic of type Blog
  • Login as LU Y
  • Comment on the topic
  • Login as LU Z
  • Reply to the comment
  • Check the emails and click on the emails buttons called "Reply to this comment"
  • It should bring you to the commented entity

Release notes

We solved the issue for reply links in e-mails regarding comments on comments, now it brings you to the commented entity.

@albertoalaejos albertoalaejos added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review prio: medium labels Oct 10, 2019
@albertoalaejos albertoalaejos added this to the 6.4 milestone Oct 10, 2019
@jaapjan
Copy link
Contributor

jaapjan commented Oct 11, 2019

Also tested the comment on a following node and that works as well.

I've one (big) remark about it. We are now linking to /node/x but then you would still need to scroll to the comment. This can be tedious. I think it would be a lot better to link to /comment/x then the redirect mechanism in Open Social will do the job for you already. Would that be easy to achieve?

@jaapjan
Copy link
Contributor

jaapjan commented Oct 11, 2019

Scratch that, I've created a follow-up for that: https://www.drupal.org/project/social/issues/3087340

@jaapjan jaapjan merged commit 158ab6a into 8.x-7.x Oct 11, 2019
@jaapjan jaapjan deleted the issue/3087042-reply-to-comment-on-comment branch October 11, 2019 08:59
jaapjan pushed a commit that referenced this pull request Oct 11, 2019
@albertoalaejos @jaapjan
issue #3087042 by albertoalaejos, bramtenhove, robertragas, jaapjan: …
946b360 
…email button for comment on comment… (#1549)

* issue #3087042 by albertoalaejos: email button for comment on comment bring you to the entity

* Issue #3087042 by jaapjan, robertragas: fix typo in token.
@jaapjan
Copy link
Contributor

jaapjan commented Oct 11, 2019

Also cherry-picked to 6.x

@jaapjan jaapjan added the backport: verified This pull request has been back ported to an older minor version label Oct 11, 2019
@navneet0693 navneet0693 removed the status: needs review This pull request is waiting for a requested review label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapjan jaapjan jaapjan left review comments

Assignees

@jaapjan jaapjan

Labels
backport: verified This pull request has been back ported to an older minor version prio: medium type: bug Fixes a bug in Open Social
Milestone
6.4
3 participants
@albertoalaejos @jaapjan @navneet0693