Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when ReShade of specific versions is also injected to the game #1836

Closed
liuxd17thu opened this issue Jun 14, 2024 · 3 comments · Fixed by #1837
Closed

Crash when ReShade of specific versions is also injected to the game #1836

liuxd17thu opened this issue Jun 14, 2024 · 3 comments · Fixed by #1837

Comments

@liuxd17thu
Copy link

How to produce:

  1. Install custom ReShade build of this commit (crosire/reshade@bb65128), or any other versions newer.
  2. Launch FFXIV with Dalamud enabled
    The Dalamud icon (for dalamud setting / plugin manager) is missing, but it should have been on the left side of game title screen.
    Meanwhile ANY keyboard input will make Dalamud crash immediately
    Crash

The game integrity is good, and there are not any Dalamud plugins installed at all. I suppose there are some conflictions between ReShade's recent code changes and Dalamud's ImGui.

Crash tspack is here:
crash-20240614131357.zip

@goaaats
Copy link
Member

goaaats commented Jun 14, 2024

Is this the exact commit that's causing the issue? Did you bisect reshade to arrive at it?

@liuxd17thu
Copy link
Author

Is this the exact commit that's causing the issue? Did you bisect reshade to arrive at it?

Yes, everything is fine with the previous commit (crosire/reshade@30abcf6).

@Soreepeong
Copy link
Contributor

Can't see any association with those reshade commits with Dalamud, but the crash log itself makes sense on its own. The above PR should fix this problem, at least for this stack trace in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants