Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitFor() semantics #38

Closed
mattmccray opened this issue Mar 5, 2015 · 1 comment
Closed

waitFor() semantics #38

mattmccray opened this issue Mar 5, 2015 · 1 comment

Comments

@mattmccray
Copy link
Contributor

Currently the waitFor method is pretty much the same as the stock Facebook one:

this.waitFor([ AStore.dispatchToken, OtherStore.dispatchToken ])

I'd like to make the dispatcher entirely an implementation detail. The waitFor method can extract the dispatcherTokens itself.

To me, this reads much nicer:

this.waitFor( AStore, OtherStore)

Or, if you feel strongly about passing an array instead of iterating the arguments:

this.waitFor([ AStore, OtherStore ])

What do you think? I'd be happy to create a PR if it's something you think fits with alt's vision of Flux.

@goatslacker
Copy link
Owner

That sounds good. If we can make it backward compatible I'm all about that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants