Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors will not match #11

Open
adam-beck opened this issue Oct 15, 2014 · 8 comments
Open

Colors will not match #11

adam-beck opened this issue Oct 15, 2014 · 8 comments

Comments

@adam-beck
Copy link

I have been trying to configure the colors for quite a while now to match the ones in the screenshot. Most of the colors appear to be showing correctly (with background=dark at least). However, it appears that the syntax groups are not configured. Now, I understand this is unrelated to mango but I'd really like to match the screenshots. I was wondering what vim javascript syntax file was being used. I have tried default, pangloss/vim-javascript, and jelera/vim-javascript-syntax.

For instance, inside of pangloss/vim-javascript it sets the prototype keywoard to the Special syntax group (Special ==> .Pink) which does not match the screenshot. Has anybody been able to reproduce the colors exactly. They do not look as good otherwise.

@goatslacker
Copy link
Owner

I use pangloss/vim-javascript I believe the screenshots are pre-prototype being changed to Special. You can always modify the vim-javascript file yourself. I'll make sure to post up new screenshots of what it looks like.

@goatslacker
Copy link
Owner

screen shot 2014-10-14 at 10 38 40 pm

@adam-beck
Copy link
Author

Well that answers my question. Thank you very much. It looks like the javascript syntax file has definitely changed. I will try to make some more screenshots for the repo. Also, have you modified your .Orange? It appears yours is much more yellow in the screenshots than mine. If I make screenshots for the repo I think they should be depicted as accurately as possible. Actually, all your colors seem to have more brightness than mine.

@goatslacker
Copy link
Owner

hmmm, not sure what that's due to. What terminal are you using?

@saamalik
Copy link

Mine:
screenshot from 2014-10-15 11 30 38

ArchLinux / XTerm
I've made minor modifications in my fork to reduce the brightness of a few colors.
My ViM and XTerm settings are available here.

@goatslacker
Copy link
Owner

btw this is the file we're screenshotting: https://github.com/jshint/fixmyjs/blob/master/lib/index.js

@goatslacker
Copy link
Owner

@saamalik if you send a PR I wouldn't mind merging in your changes.

@saamalik
Copy link

@goatslacker sure--let me first make sure the corresponding brightness are applied to both GViM and terminal ViM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants