Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy provider HTTP-Basic Password not obfuscated #265

Closed
tigattack opened this issue Oct 7, 2020 · 1 comment
Closed

Proxy provider HTTP-Basic Password not obfuscated #265

tigattack opened this issue Oct 7, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@tigattack
Copy link
Contributor

Describe the bug
In the edit page of a proxy provider, the HTTP-Basic password is shown in plaintext.

To Reproduce
Steps to reproduce the behavior:

  1. Create proxy provider with any set of credentials.
  2. Save.
  3. Edit the provider.
  4. See plaintext password.

Expected behavior
This should be obfuscated.

Screenshots
N/A.

Logs
N/A.

Version and Deployment (please complete the following information):

  • passbook version: 0.10.9-stable
  • Deployment: docker-compose

Additional context
N/A.

@tigattack tigattack added the bug Something isn't working label Oct 7, 2020
@BeryJu BeryJu added this to the Release 0.11 milestone Oct 7, 2020
@BeryJu
Copy link
Member

BeryJu commented Oct 7, 2020

I assume you mean the HTTP-Basic Password field? This field doesn't hold the actual password, it saves which user or group attribute should be used for the password.

The help_text doesn't describe that 100% clearly, I'll update it.

@BeryJu BeryJu closed this as completed in c1eb831 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants