Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: add missing checkbox element in user settings #2762

Merged
merged 1 commit into from May 7, 2022

Conversation

tomtom5152
Copy link
Contributor

Details

  • Does this resolve an issue?
    Minor: checkbox is missing in user settings.

Changes

New Features

  • Add checkbox element to user settings PrompStage.
  • Add required CSS elements to style it correctly.

Additional

The default PromptStage handles checkboxes different in renderField, the user settings one does not do this and cannot do it whilst maintaining horizontal styling. This change extends the existing renderPromptInner to add checkbox support for this edge case.

There may be a better way of doing this, this is my first contribution, all be it minor, so very much learning the frameworks and codebase.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2762 (4dec5b6) into master (9077eff) will increase coverage by 61.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2762       +/-   ##
===========================================
+ Coverage   30.45%   91.73%   +61.29%     
===========================================
  Files         455      455               
  Lines       20038    20037        -1     
===========================================
+ Hits         6100    18379    +12279     
+ Misses      13938     1658    -12280     
Impacted Files Coverage Δ
authentik/root/settings.py 89.44% <0.00%> (ø)
authentik/outposts/models.py 87.29% <0.00%> (+2.64%) ⬆️
authentik/sources/oauth/types/mailcow.py 68.75% <0.00%> (+3.13%) ⬆️
authentik/outposts/tasks.py 79.32% <0.00%> (+3.45%) ⬆️
authentik/stages/authenticator_sms/models.py 62.50% <0.00%> (+4.55%) ⬆️
authentik/lib/utils/reflection.py 79.49% <0.00%> (+5.13%) ⬆️
authentik/sources/oauth/types/azure_ad.py 72.23% <0.00%> (+5.56%) ⬆️
authentik/sources/oauth/types/github.py 100.00% <0.00%> (+5.56%) ⬆️
authentik/outposts/controllers/base.py 98.08% <0.00%> (+5.77%) ⬆️
authentik/sources/oauth/types/google.py 100.00% <0.00%> (+5.89%) ⬆️
... and 387 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9077eff...4dec5b6. Read the comment docs.

@tomtom5152
Copy link
Contributor Author

Force pushed prettier output, forgot to run it first time before committing

@BeryJu BeryJu merged commit 948d2cb into goauthentik:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants