Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fix authentification with Plex on iOS #4095

Merged
merged 3 commits into from Dec 1, 2022
Merged

Conversation

babariviere
Copy link
Contributor

@babariviere babariviere commented Nov 26, 2022

Details

Resolves #3822.
This has been tested on iOS 16 on my iPhone.

Changes

Additional

Create the popup window for Plex in the main thread using setTimeout. This is done to fix iOS authentication, since it's not allowed to create a window from an async function on safari.

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 55.28% // Head: 92.76% // Increases project coverage by +37.49% 🎉

Coverage data is based on head (26c06b4) compared to base (be9790e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4095       +/-   ##
===========================================
+ Coverage   55.28%   92.76%   +37.49%     
===========================================
  Files         474      474               
  Lines       23186    23207       +21     
===========================================
+ Hits        12815    21526     +8711     
+ Misses      10371     1681     -8690     
Flag Coverage Δ
e2e 53.93% <ø> (-0.04%) ⬇️
integration 27.52% <ø> (-0.06%) ⬇️
unit 89.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/outposts/tasks.py 78.66% <0.00%> (+0.57%) ⬆️
authentik/flows/models.py 97.37% <0.00%> (+0.88%) ⬆️
authentik/providers/saml/processors/metadata.py 100.00% <0.00%> (+1.25%) ⬆️
authentik/providers/saml/processors/assertion.py 89.19% <0.00%> (+1.63%) ⬆️
authentik/core/api/authenticated_sessions.py 100.00% <0.00%> (+1.70%) ⬆️
authentik/sources/oauth/clients/base.py 94.45% <0.00%> (+1.86%) ⬆️
authentik/events/signals.py 100.00% <0.00%> (+1.97%) ⬆️
authentik/sources/saml/processors/request.py 100.00% <0.00%> (+2.36%) ⬆️
authentik/stages/invitation/api.py 100.00% <0.00%> (+2.57%) ⬆️
authentik/lib/utils/reflection.py 78.38% <0.00%> (+2.71%) ⬆️
... and 328 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Nov 30, 2022

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 26c06b4
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/638891c186fcba000d1b95ce
😎 Deploy Preview https://deploy-preview-4095--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
@BeryJu BeryJu merged commit 93fee5f into goauthentik:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plex login doesn't work on mobile
2 participants