Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix mismatched task names for discovery, make output service connection task monitored #4956

Merged
merged 1 commit into from Mar 15, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Mar 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 70.00% and no project coverage change.

Comparison is base (109f06c) 92.78% compared to head (f5b775c) 92.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4956      +/-   ##
==========================================
- Coverage   92.78%   92.77%   -0.00%     
==========================================
  Files         501      501              
  Lines       25467    25470       +3     
==========================================
+ Hits        23626    23627       +1     
- Misses       1841     1843       +2     
Flag Coverage Δ
e2e 52.78% <35.00%> (-0.01%) ⬇️
integration 26.52% <45.00%> (+0.01%) ⬆️
unit 89.53% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/blueprints/settings.py 100.00% <ø> (ø)
authentik/outposts/settings.py 100.00% <ø> (ø)
authentik/root/celery.py 77.20% <0.00%> (ø)
authentik/blueprints/v1/tasks.py 73.62% <50.00%> (ø)
authentik/outposts/tasks.py 78.34% <66.67%> (-0.19%) ⬇️
authentik/blueprints/tests/test_v1_tasks.py 100.00% <100.00%> (ø)
authentik/events/monitored_tasks.py 97.23% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ction task monitored

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the root/fix-mismatched-task-names branch from 8c1e25b to f5b775c Compare March 15, 2023 10:52
@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit f5b775c
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6411a36a220d3f000892c68e
😎 Deploy Preview https://deploy-preview-4956--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-fix-mismatched-task-names-1678878106-ff9a771
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-fix-mismatched-task-names-1678878106-ff9a771-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-fix-mismatched-task-names-1678878106-ff9a771

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-fix-mismatched-task-names-1678878106-ff9a771-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 9310d4c into main Mar 15, 2023
45 of 47 checks passed
@BeryJu BeryJu deleted the root/fix-mismatched-task-names branch March 15, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant