Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add unique constraint to user UUID #5004

Merged
merged 3 commits into from Mar 19, 2023
Merged

Conversation

sdimovv
Copy link
Contributor

@sdimovv sdimovv commented Mar 19, 2023

Details

  • Does this resolve an issue?
    N/A

Changes

New Features

  • Add unique constraind to user UUID.

Breaking Changes

N/A

Additional

Even though a collision is extremely unlikely, the UUID field is not the primary key, so it needs to be explicitly set to be unique.

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.21 🎉

Comparison is base (a566856) 91.57% compared to head (39adeb3) 92.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5004      +/-   ##
==========================================
+ Coverage   91.57%   92.77%   +1.21%     
==========================================
  Files         501      501              
  Lines       25617    25617              
==========================================
+ Hits        23456    23764     +308     
+ Misses       2161     1853     -308     
Flag Coverage Δ
e2e 52.62% <100.00%> (+0.98%) ⬆️
integration 26.46% <100.00%> (?)
unit 89.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/core/models.py 92.39% <100.00%> (ø)

... and 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 16a0316 into goauthentik:main Mar 19, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants