Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/authenticator_validate: fix stage not working without pending user #5096

Merged
merged 1 commit into from Mar 27, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Mar 27, 2023

closes #5094

…user

closes #5094

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (a7fc579) 92.77% compared to head (67b0962) 92.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5096      +/-   ##
==========================================
- Coverage   92.77%   92.75%   -0.01%     
==========================================
  Files         506      506              
  Lines       25779    25797      +18     
==========================================
+ Hits        23913    23925      +12     
- Misses       1866     1872       +6     
Flag Coverage Δ
e2e 52.64% <4.00%> (-0.06%) ⬇️
integration 26.36% <0.00%> (-0.01%) ⬇️
unit 89.57% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/stages/authenticator_validate/stage.py 84.62% <100.00%> (+0.30%) ⬆️
.../stages/authenticator_validate/tests/test_stage.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator_validate-fix-non-authentication-1679950026-50376af
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator_validate-fix-non-authentication-1679950026-50376af-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator_validate-fix-non-authentication-1679950026-50376af

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator_validate-fix-non-authentication-1679950026-50376af-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 4218ece into main Mar 27, 2023
53 of 54 checks passed
@BeryJu BeryJu deleted the stages/authenticator_validate/fix-non-authentication branch March 27, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFA Flow "Request Denied"
1 participant