Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle: don't use celery ping for worker healthcheck #5153

Merged
merged 1 commit into from Apr 3, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 3, 2023

closes #4707

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 63.16% and project coverage change: -38.96 ⚠️

Comparison is base (a92786e) 92.74% compared to head (668b358) 53.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5153       +/-   ##
===========================================
- Coverage   92.74%   53.78%   -38.96%     
===========================================
  Files         506      506               
  Lines       25808    25826       +18     
===========================================
- Hits        23933    13887    -10046     
- Misses       1875    11939    +10064     
Flag Coverage Δ
e2e 52.63% <63.16%> (-0.02%) ⬇️
integration 26.35% <63.16%> (+0.03%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/root/celery.py 66.67% <63.16%> (-10.52%) ⬇️

... and 359 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the root/rework-celery-healthcheck branch from 97fb68a to 668b358 Compare April 3, 2023 16:03
@BeryJu BeryJu merged commit 02f75a9 into main Apr 3, 2023
52 of 54 checks passed
@BeryJu BeryJu deleted the root/rework-celery-healthcheck branch April 3, 2023 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-rework-celery-healthcheck-1680538367-2c85d3d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-rework-celery-healthcheck-1680538367-2c85d3d-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-rework-celery-healthcheck-1680538367-2c85d3d

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-rework-celery-healthcheck-1680538367-2c85d3d-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celery CPU usage 100% on new install
1 participant