Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarative blueprints (based on file exists) #5300

Open
genofire opened this issue Apr 18, 2023 · 3 comments
Open

Declarative blueprints (based on file exists) #5300

genofire opened this issue Apr 18, 2023 · 3 comments
Labels
enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request

Comments

@genofire
Copy link

genofire commented Apr 18, 2023

Is your feature request related to a problem? Please describe.
A option to define a state of resources by an blueprint (Declarative). And not like current define a change/migration (Procedural).

Describe the solution you'd like
That if file is detected the resources are created / updated (like state: present) and remove of the file would delete resources (like state: absent) with an new state type like state: watch

Describe alternatives you've considered
easy way to remove based on an blueprint yaml file (without change of file).

Additional context
it is for me like ansible vs. terraform ....

@genofire genofire added the enhancement New feature or request label Apr 18, 2023
@genofire genofire changed the title blueprint based on file exists declarative blueprint (based on file exists) Apr 18, 2023
@genofire genofire changed the title declarative blueprint (based on file exists) Declarative blueprints (based on file exists) Apr 18, 2023
@benedikt-bartscher
Copy link

benedikt-bartscher commented Apr 21, 2023

I really like this approach, i prevents from accidential blueprint deletion if something goes wrong (for example you are missing a volume mount in k8). But it still allows blueprints to be deleted in a declarative way.

@genofire
Copy link
Author

genofire commented Apr 21, 2023

(a mount happens bevor the container starts in k8s - i prefer a sidecar which reads from configmap, see my helmchart PR goauthentik/helm#146)

after the blueprints are there (again), it will create again (so if an outage happen it will be fixed automaticaly)

@benedikt-bartscher
Copy link

Yes i know, thats the current behaviour. but with declarative blueprints (this issue) you could prevent the outage completly, even if the blueprints get lost (state: present).
But you can also intentionally delete blueprints (state: absent) or keep the current watch behaviour (state: watch). That is why i like your approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants