Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: always run policies for notification rules even if no group is selected #5353

Merged
merged 1 commit into from Apr 23, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 23, 2023

No description provided.

…s selected

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@netlify
Copy link

netlify bot commented Apr 23, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit c54cb6b
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/644553eb33cdee0008c150cb
😎 Deploy Preview https://deploy-preview-5353--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (5c8f024) 92.72% compared to head (c54cb6b) 92.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5353      +/-   ##
==========================================
- Coverage   92.72%   92.61%   -0.10%     
==========================================
  Files         506      506              
  Lines       25908    25908              
==========================================
- Hits        24021    23993      -28     
- Misses       1887     1915      +28     
Flag Coverage Δ
e2e 51.89% <0.00%> (-0.74%) ⬇️
integration 26.26% <0.00%> (-0.05%) ⬇️
unit 89.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/events/tasks.py 79.13% <100.00%> (ø)

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 5970a6e into main Apr 23, 2023
55 of 57 checks passed
@BeryJu BeryJu deleted the events/always-run-policies branch April 23, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant